pb-4000: Increased the value of shortRetryTimeout to 5mints. #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siva-portworx
requested review from
lalat-das,
diptiranjanpx,
prashanthpx,
px-kesavan,
sgajawada-px and
pallav-px
|
Can one of the admins verify this patch? |
prashanthpx
approved these changes
Jul 19, 2023
- On some of the platform, the deletion of the job pod that we create to temporarily to bound the "waitForFirstConsumer" volumebind mode PVC takes time. - So increased the timeout value for the waiting for the bound to be deleted to 5 minutes from 30 sec.
pallav-px
approved these changes
Jul 19, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1454 +/- ##
==========================================
- Coverage 66.11% 66.05% -0.07%
==========================================
Files 43 43
Lines 4984 4984
==========================================
- Hits 3295 3292 -3
- Misses 1371 1373 +2
- Partials 318 319 +1 ☔ View full report in Codecov by Sentry. |
|
Only code coverage failed. So force pushing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Does this PR change a user-facing CRD or CLI?:
No
Is a release note needed?:
Does this change need to be cherry-picked to a release branch?:
23.6.1 branch.
Testing:
Validated the fix on the azure setup, where we were seeing timeout failure.